Improve environment management #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdispater
added
area/cli
sdispater
force-pushed
the
improve-env-management
branch
from
c5b5279
to
0f9eaed
Compare
|
That's great thanks @sdispater ! |
michielboekhoff
pushed a commit
to michielboekhoff/poetry
that referenced
this pull request
Oct 29, 2019
* Refactor the environment management code * Improve executable selection when current Python is incompatible
michielboekhoff
pushed a commit
to michielboekhoff/poetry
that referenced
this pull request
Oct 29, 2019
* Refactor the environment management code * Improve executable selection when current Python is incompatible
This was referenced Oct 31, 2019
Congee
reviewed
Nov 1, 2019
| ) | ||
| ) | ||
|
|
||
| for python_to_try in reversed( |
2 tasks
2 tasks
1 task
3 tasks
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This PR should fix or at least alleviate issues that users face when trying to setup a project with a python requirement that is not compatible with the currently used Python version (see #536).
The environment manager will now try to find a compatible Python version in the current path and use/activate it accordingly. Note that it will still fail if none can be found but with, hopefully, a better error message with some pointers as to how the user can solve the problem.