Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repositories): remove type errors #5255

Merged
merged 1 commit into from
May 15, 2022

Conversation

branchvincent
Copy link
Member

Distribution seems to be mostly an abstract class, with a single concrete PathDistribution. We assume we're working with aPathDistribution, which has a _path but not publicly typed, so not sure what else to do besides type: ignore

@dimbleby
Copy link
Contributor

dimbleby commented Mar 2, 2022

I think that you are running the typechecking only through precommit? That runs in an environment that does not install most of the poetry dependencies, and as a result it misses most of the errors. So I believe that this MR - or if not specifically this MR then the recent sequence of typechecking MRs - is in a false paradise.

https://gist.github.com/dimbleby/b9133cbafee6e127418a538bd7986f75 is the set of errors that I currently get when running mypy from within the poetry environment.

@dimbleby
Copy link
Contributor

dimbleby commented Mar 5, 2022

#5279

@branchvincent
Copy link
Member Author

I think that you are running the typechecking only through precommit?

good catch! you're definitely right, thanks for calling that out

@dimbleby
Copy link
Contributor

Looks good to me - I also don't see a better way.

@neersighted neersighted merged commit f33c9db into python-poetry:master May 15, 2022
@branchvincent branchvincent deleted the mypy/repositories branch May 16, 2022 16:15
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants