Code Quality: Incremental adoption of mypy type checks

[finswimmer]

poetry and poetry-core are full type annotated and checking types by mypy is prepared. However these checks are deactivated for most of the modules.

In this ticket I like to invite everybody to pick one or more modules in poetry and poetry-core and fix errors reported by mypy. Please link any PR you are starting to this issue.

In process:

• Type checking poetry-core#253
• chore(utils): remove type errors #5262
• chore(installation): remove type errors #5260
• chore(console): remove type errors #5258
• chore(repositories): remove type errors #5255
• mypy type checks in password_manager #5399
• solved mypy errors for poetry.mixology #5402

[dimbleby]

@finswimmer can I suggest that you'll likely get better engagement with this sort of thing if maintainers are able to merge the PRs reasonably promptly? I know that I would much more likely have felt encouraged to continue the work of python-poetry/poetry-core#253 if I saw it being committed.

[finswimmer]

Hello @dimbleby,

I'm one of the maintainers (just if you haven't know it). I absolutely agree with your sentiment that reacting on a PR in short time would get better engagement. But unfortunately this is not always possible. I think you already know it. We are all doing this in our free time. And sometimes one has to decide whether to review a PR a comment on some of the 30-50 new issues/questions/feature request per week. Some reviews require also discussion between the maintainers, which takes time.

If you feel that something takes to long, please ping us in the isssue/PR or on the discord server.

fin swimmer

[dimbleby]

I intend no upset, I'm here because I think poetry is a good thing, and I'm nothing but grateful to those who've got us this far. Please be assured that I am not trying to knock or discourage anyone, my apologies if it seemed otherwise.

But yeah, my experience is that contributing to poetry generally is a slow business. Probably #4595 would have been a better place to talk about it though.

[abn]

@krakenbite this is already under way. I'd recommend you pick a module or test ignored (https://github.com/python-poetry/poetry/blob/master/pyproject.toml#L113) and fix it. Don't try to do it all in a single PR that's hard to review. :)

[tarun-jethwani]

Hi @abn @python-poetry/triage @finswimmer, I would also like to work on this issue, infact started working on it, I am a first time contributor to poetry, have already read Contributing.md guidelines and familiar with necessary practices, I would like to submit PR one per module out of all the approx. 25 modules listed under [[tool.mypy.overrides]] , for starting I would like to pick up this "poetry.console.application" module,

I will also try to submit PR with only closely related changes and will not try not to do too much at once in single PR, I will first try to submit a Draft PR first

[tarun-jethwani]

Hi @abn, @finswimmer @branchvincent , I will take up poetry.mixology to solve for mypy errors, as there is already an open PR for poetry.console

[anthonymichaelclark]

Link to PR for password_manager

[tarun-jethwani]

@branchvincent please review my PR [https://github.com//pull/5402] - fix for mypy errors in poetry.mixology package

[tarun-jethwani]

Hi @abn , @finswimmer , @branchvincent @dimbleby , Please approve my PR https://github.com/python-poetry/poetry/pull/5402 pending since yesterday, I have completed all the required changes

[tarun-jethwani]

Hi @abn , @finswimmer , @branchvincent , I have resolved merge conflicts in this PR fix mypy errors for poetry.mixology , please review this PR

[dimbleby]

open typechecking MRs (list may not be complete) include

• more typechecking #5635
• typechecking poetry.utils.env #5658

Aside from the minor detail that these aren't yet merged, we're very nearly done!

[Secrus]

As of today, only poetry.utils.env is left to be properly typed. Good job everyone!

[Secrus]

This is now completed.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.