Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(console): remove type errors #5258

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

eyllanesc
Copy link
Contributor

No description provided.

@eyllanesc eyllanesc changed the title chore(console/application): remove type errors chore(console): remove type errors Mar 2, 2022
branchvincent
branchvincent previously approved these changes Mar 2, 2022
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyllanesc thanks for your contribution! This looks good to me. We'll just need to wait for another maintainer to approve/merge

neersighted
neersighted previously approved these changes Mar 2, 2022
@eyllanesc eyllanesc dismissed stale reviews from neersighted and branchvincent via a31881c March 2, 2022 15:41
@dimbleby
Copy link
Contributor

dimbleby commented Mar 5, 2022

#5279

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eyllanesc! I think we can handle running mypy in the proper environment separately

@branchvincent branchvincent merged commit 9b8d830 into python-poetry:master Apr 1, 2022
@eyllanesc eyllanesc deleted the mypy/console branch April 1, 2022 13:37
@kasteph kasteph mentioned this pull request May 30, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants