Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit app_label #12

Merged
merged 1 commit into from
Jan 21, 2017
Merged

Add explicit app_label #12

merged 1 commit into from
Jan 21, 2017

Conversation

rgaiacs
Copy link
Contributor

@rgaiacs rgaiacs commented Jan 9, 2017

This pull request will solve #11.

Test instructions

To test the pull request with my broken app I had to install https://github.com/python-social-auth/social-app-django/ and https://github.com/python-social-auth/social-core.

$ git clone https://github.com/python-social-auth/social-core.git
$ cd social-core
$ python setup.py install
$ cd ..
$ git clone https://github.com/python-social-auth/social-app-django.git
$ cd social-app-django
$ python setup.py install

Extra changes

I had to replace

'social.apps.django_app.context_processors.backends',

with

'social_django.context_processors.backends',

and

url('', include('social.apps.django_app.urls', namespace='social')),

with

url('', include('social_django.urls', namespace='social')),

on my broken app.

@omab omab merged commit 24b4dbe into python-social-auth:master Jan 21, 2017
@omab
Copy link
Contributor

omab commented Jan 21, 2017

Thanks!

@ticosax
Copy link

ticosax commented Jan 21, 2017

Are you sure this should have been merged ? the error was due to a misconfiguration.
app_label is already "social_django". We don't need to hardcode it.

@omab
Copy link
Contributor

omab commented Jan 21, 2017

It's not required but doesn't make any harm also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants