New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V20 updates #47
V20 updates #47
Conversation
# Conflicts: # ptbcontrib/reply_to_message_filter/requirements.txt
I already did the code upgrade for the API wrapper, not the tests yet though. It is in the public branch. |
@Poolitzer Thanks for the heads up 👍 |
@Bibo-Joshi I opened #48 for the wrapper, have a look. |
# Conflicts: # ptbcontrib/roles/__init__.py # ptbcontrib/roles/roles.py # ptbcontrib/roles/roleshandler.py # requirements-dev.txt # run_tests.py # setup.cfg # tests/conftest.py # tests/test_get_chat_link.py # tests/test_reply_to_message_filter.py # tests/test_roles.py # tests/test_send_by_kwargs.py
Don't understand why the tests started to fail after mergin #46. WIll try to investigate sometime later |
* Update Prostgres Persistence * Fix conversations & Drop unused function
upgrading the jobstore contribution is not yet included in this PR, but I guess we don't have to wait for that - and rather not forget about this PR :D @harshil21 @Poolitzer if one of you could give the changes a rough second look, that would be awesome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comment things
so far:
ReplyToMessageFilter
send_by_kwargs
#39)Roles.chat_admins/owner
thingies, which made api requests in thecheck_update
(rather:filter
) step. Don't know why I even thought that were a good idea …Based on #46. Selected that branch as target so that it's easier to see the changes. Should be merged into baster once #46 is merged.