V20 username wrapper #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrapper # Conflicts: # ptbcontrib/username_to_chat_api/usernametochatapi.py
Also fixed a wrong error raising
Merged
Poolitzer
commented
May 22, 2022
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Also improve example
Bibo-Joshi
reviewed
May 23, 2022
Comment on lines
43
to
46
| if "wrapper" not in application.bot_data: | ||
| wrapper: UsernameToChatAPI = UsernameToChatAPI("https://localhost:1234/", | ||
| "RationalGymsGripOverseas", application.bot) | ||
| application.bot_data["wrapper"] = wrapper |
There was a problem hiding this comment.
uhm, stupid question again: why do this here and not just directly in the main with application.bot_data["wapper"] = UsernameToChatApi(…)? The main advantage of using a custom context class would be that you e.g. have it directly accessible via context.wrapper - for that I would do something like
class CustomContext(CallbackContext[insert type vars here]):
@property
def wrapper(self) -> UsernameToChatAPI:
return self.bot_data["wrapper"]also revampp the customcontext example
Bibo-Joshi
reviewed
May 23, 2022
Comment on lines
41
to
42
| def __init__(self, application: Application): | ||
| super().__init__(application=application) |
There was a problem hiding this comment.
no need for init now :) yes, I'm pick 🙆♂️
There was a problem hiding this comment.
Grmpf you could have said that earlier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.