Fix Filters.regex failing on non-text message (#1158)

* Fix #1115 * Improve regex filter test
python-telegram-bot · Aug 26, 2018 · 8acff56 · 8acff56
1 parent d4b5bd4
commit 8acff56
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/telegram/ext/filters.py b/telegram/ext/filters.py
@@ -198,7 +198,9 @@ def __init__(self, pattern):
         # the matched groups and groupdict to the context object.
 
         def filter(self, message):
-            return bool(self.pattern.search(message.text))
+            if message.text:
+                return bool(self.pattern.search(message.text))
+            return False
 
     class _Reply(BaseFilter):
         name = 'Filters.reply'

diff --git a/tests/test_filters.py b/tests/test_filters.py
@@ -68,6 +68,9 @@ def test_filters_regex(self, message):
         message.text = 'i love python'
         assert Filters.regex(r'.\b[lo]{2}ve python')(message)
 
+        message.text = None
+        assert not Filters.regex(r'fail')(message)
+
     def test_filters_reply(self, message):
         another_message = Message(1, User(1, 'TestOther', False), datetime.datetime.now(),
                                   Chat(0, 'private'))