Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filters.regex failing on non-text message #1158

Merged
merged 2 commits into from
Aug 26, 2018
Merged

Fix Filters.regex failing on non-text message #1158

merged 2 commits into from
Aug 26, 2018

Conversation

icekom
Copy link
Contributor

@icekom icekom commented Jul 11, 2018

Fix #1115 and improve test_filters_regex

@icekom icekom changed the title Fix #1115 Fix Filters.regex failing on non-text message Jul 11, 2018
Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :)

@alisherafat01
Copy link

Please merge and fix this bug. i need this

@jsmnbom
Copy link
Member

jsmnbom commented Aug 26, 2018

Merging. tests will fail until #1168 is merged since we are not compliant with the official api until then.

@jsmnbom jsmnbom merged commit 8acff56 into python-telegram-bot:master Aug 26, 2018
@icekom icekom deleted the fix-1115 branch August 26, 2018 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters.regex fails on non-text messages
3 participants