Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filters.regex failing on non-text message #1158

Merged
merged 2 commits into from Aug 26, 2018

Conversation

Projects
None yet
3 participants
@icecom-dg
Copy link
Contributor

icecom-dg commented Jul 11, 2018

Fix #1115 and improve test_filters_regex

Dmitriy Grigoryev added some commits Jul 11, 2018

@icecom-dg icecom-dg changed the title Fix #1115 Fix Filters.regex failing on non-text message Jul 11, 2018

@jsmnbom
Copy link
Member

jsmnbom left a comment

This looks good to me :)

@alisherafat01

This comment has been minimized.

Copy link

alisherafat01 commented Aug 24, 2018

Please merge and fix this bug. i need this

@jsmnbom

This comment has been minimized.

Copy link
Member

jsmnbom commented Aug 26, 2018

Merging. tests will fail until #1168 is merged since we are not compliant with the official api until then.

@jsmnbom jsmnbom merged commit 8acff56 into python-telegram-bot:master Aug 26, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@icecom-dg icecom-dg deleted the icecom-dg:fix-1115 branch Aug 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.