-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sommer/Winter time with Jobs #1381
Comments
tsnoam
added a commit
that referenced
this issue
Apr 26, 2019
tsnoam
added a commit
that referenced
this issue
Apr 26, 2019
@Bibo-Joshi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
Live in Europe
Run a weekly job with something like
Expected behaviour
Job runs once a week at the specified time
Actual behaviour
The clock change from winter to sommer time is not handled correctly and the job runs an hour early/late.
Proposal:
Since the problem occurs only twice a year and is easily fixed by restarting the bot and this nonsence of constantly changing clocks hopefully ends by 2021, I guess this can be "fixed" by documenting it in the docstring of
JobQueue.run_daily()
andJobQueue.run_repeating()
.If I get a LGTM for this "solution", I'll open a PR for it :)
The text was updated successfully, but these errors were encountered: