Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sommer/Winter time with Jobs #1381

Closed
Bibo-Joshi opened this issue Apr 10, 2019 · 1 comment · Fixed by #1397
Closed

Sommer/Winter time with Jobs #1381

Bibo-Joshi opened this issue Apr 10, 2019 · 1 comment · Fixed by #1397

Comments

@Bibo-Joshi
Copy link
Member

Steps to reproduce

  1. Live in Europe

  2. Run a weekly job with something like

first = datetime(foo)
job_queue.run_repeating(job,
                        interval = timedelta(7),
                        first = first)

Expected behaviour

Job runs once a week at the specified time

Actual behaviour

The clock change from winter to sommer time is not handled correctly and the job runs an hour early/late.

Proposal:

Since the problem occurs only twice a year and is easily fixed by restarting the bot and this nonsence of constantly changing clocks hopefully ends by 2021, I guess this can be "fixed" by documenting it in the docstring of JobQueue.run_daily() and JobQueue.run_repeating().
If I get a LGTM for this "solution", I'll open a PR for it :)

@tsnoam
Copy link
Member

tsnoam commented Apr 26, 2019

@Bibo-Joshi
Thanks for the report. The documentation will be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants