New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater improvements #1018

Merged
merged 8 commits into from Mar 2, 2018

Conversation

Projects
None yet
2 participants
@tsnoam
Member

tsnoam commented Feb 22, 2018

  • Refactor bootstrap phase to be resilient for network errors
  • Improved unitests for polling updater

fixes #605

@tsnoam tsnoam requested a review from Eldinnie Feb 22, 2018

Show outdated Hide outdated telegram/ext/updater.py
Show outdated Hide outdated telegram/ext/updater.py
Show outdated Hide outdated telegram/ext/updater.py
Show outdated Hide outdated telegram/ext/updater.py
raise
self.logger.debug('{0} - ended'.format(thr_name))
def start_polling(self,
poll_interval=0.0,
timeout=10,
clean=False,
bootstrap_retries=0,
bootstrap_retries=-1,

This comment has been minimized.

@Eldinnie

Eldinnie Mar 1, 2018

Member

The docstring doesn;t reflect this change to the default value

@Eldinnie

Eldinnie Mar 1, 2018

Member

The docstring doesn;t reflect this change to the default value

This comment has been minimized.

@tsnoam

tsnoam Mar 1, 2018

Member

will fix

@tsnoam

tsnoam Mar 1, 2018

Member

will fix

@Eldinnie

This comment has been minimized.

Show comment
Hide comment
@Eldinnie

Eldinnie Mar 1, 2018

Member

I just left some review comments.
Some small, but regarding the _bootstrap() method I would really like to avoid unnecessary API calls regarding the webhook methods if possible. You see a way to change that?

Member

Eldinnie commented Mar 1, 2018

I just left some review comments.
Some small, but regarding the _bootstrap() method I would really like to avoid unnecessary API calls regarding the webhook methods if possible. You see a way to change that?

@Eldinnie

This comment has been minimized.

Show comment
Hide comment
@Eldinnie

Eldinnie Mar 2, 2018

Member

Yes good!

Member

Eldinnie commented Mar 2, 2018

Yes good!

@tsnoam tsnoam merged commit a6bf456 into master Mar 2, 2018

3 of 5 checks passed

codecov/patch 81.39% of diff hit (target 92.32%)
Details
codecov/project 92.29% (-0.04%) compared to b275031
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@tsnoam tsnoam deleted the resilient_bootstrap branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment