-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updater improvements #1018
Merged
Merged
Updater improvements #1018
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ce447b8
updater: Refactor bootstrap phase to be resilient for network errors
tsnoam fc98577
Improved unitests for polling updater
tsnoam c5f0ed8
Remove logs which shouldn't have been commited
tsnoam b7c9ace
Merge remote-tracking branch 'origin/master' into resilient_bootstrap
tsnoam 66a03ee
FIx documentation of start_polling() with new bootstrap_retries value
tsnoam 597c9f5
Move _clean_updates() into inner procedure bootstrap_clean_updates()
tsnoam 152d034
squash! FIx documentation of start_{polling,webhook}() with new boots…
tsnoam aa35961
Don't call set_webhook with empty url - redundant to del_webhook
tsnoam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring doesn;t reflect this change to the default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix