Fix in telegram.Message #1042
Merged
Fix in telegram.Message #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_parse_(html|markdown)` methods now properly return `None` on an empty `Message.text` or an empty `Message.caption`
jh0ker
requested changes
Mar 12, 2018
tests/test_message.py
Outdated
| def test_text_html_empty(self, message): | ||
| message.text = None | ||
| message.caption = "test" | ||
| assert not message.text_html |
There was a problem hiding this comment.
Perhaps change to assert message.text_html is None ?
There was a problem hiding this comment.
same for the other tests of course
There was a problem hiding this comment.
Because it would properly test the feature. We don't want to allow empty strings, right?
There was a problem hiding this comment.
I don't see why not, actually I was think of doing:
if not message_text:
return message_text
jh0ker
approved these changes
Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_parse_(html|markdown)methods now properly returnNoneon an emptyMessage.textor an emptyMessage.caption