Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updates persist even on DispatcherHandlerStop #1463

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Aug 5, 2019

Raising a DispatcherHandlerStop prevents handlers in other groups from being executed. Due to the construction of process_update in the Dispatcher, the update is not persisted in that case, since line 334 is not executed.

This is usually no problem, since all data is persisted on showtdown (from the Updater). However, when trying to acces the persisted files between updates or when a clean shutdown fails, this is an issue.

Hence, persistence should be handled also in line 352.

To avoid copy-pasting, I added a local method for handling the persistence and inserted it at both line 334 and 352.

@tsnoam tsnoam merged commit 5e90231 into python-telegram-bot:master Aug 23, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@Bibo-Joshi Bibo-Joshi deleted the Bibo-Joshi:persist-dp-stop branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.