Make updates persist even on DispatcherHandlerStop #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising a
DispatcherHandlerStopprevents handlers in other groups from being executed. Due to the construction ofprocess_updatein theDispatcher, the update is not persisted in that case, since line 334 is not executed.This is usually no problem, since all data is persisted on showtdown (from the
Updater). However, when trying to acces the persisted files between updates or when a clean shutdown fails, this is an issue.Hence, persistence should be handled also in line 352.
To avoid copy-pasting, I added a local method for handling the persistence and inserted it at both line 334 and 352.