Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC in from_timestamp #1485

Merged
merged 1 commit into from Aug 28, 2019
Merged

Use UTC in from_timestamp #1485

merged 1 commit into from Aug 28, 2019

Conversation

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Aug 27, 2019

Closes #1362

By the discussion in #1409 and #1451 I had the impression that timezone aware datetime objects are to avoided and hence I used utcfromtimestamp instead of fromtimestamp(unixtime, tz=timezone.utc). If this was the false conclusion, please let me know.

Bibo-Joshi
@tsnoam tsnoam merged commit 425912d into master Aug 28, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@tsnoam tsnoam deleted the fix-1362 branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.