-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark data for persistence update #3607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just different wording suggestions, code is a great change!
telegram/ext/_application.py
Outdated
Note that for data that should be available globally in all handler callbacks, | ||
independent of the chat/user, it is recommended use :attr:`bot_data` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that for data that should be available globally in all handler callbacks, | |
independent of the chat/user, it is recommended use :attr:`bot_data` instead. | |
Note that for data which should be available globally in all handler callbacks, | |
e.g. independent of the chat/user, it is recommended to use :attr:`bot_data` instead. |
telegram/ext/_application.py
Outdated
For :attr:`user_data` and :attr:`chat_data`, only those entries are updated that were used | ||
or manually marked via :meth:`mark_data_for_update_persistence` since the last run of this | ||
method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For :attr:`user_data` and :attr:`chat_data`, only those entries are updated that were used | |
or manually marked via :meth:`mark_data_for_update_persistence` since the last run of this | |
method. | |
For :attr:`user_data` and :attr:`chat_data`, only the entries are updated which either were | |
used or have been manually marked via :meth:`mark_data_for_update_persistence` since | |
the last run of this method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #3554. Closes #3601
Checklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added myself alphabetically toAUTHORS.rst
(optional)Added new classes & modules to the docs and all suitable__all__
s