New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with GAE via urllib3.contrib package #583

Merged
merged 2 commits into from Apr 29, 2017

Conversation

Projects
None yet
2 participants
@whipermr5
Contributor

whipermr5 commented Apr 27, 2017

Fixes #334

Checks whether app is running inside Google App Engine; uses urllib3.contrib.appengine.AppEngineManager instead of urllib3.PoolManager if it is (more info about the urllib3.contrib package here). This makes use of App Engine's URLFetch service instead of the sockets API, which is not available in non-billable apps.

@tsnoam

This comment has been minimized.

Show comment
Hide comment
@tsnoam

tsnoam Apr 29, 2017

Member

@whipermr5 Thank you for your contribution.

Member

tsnoam commented Apr 29, 2017

@whipermr5 Thank you for your contribution.

@tsnoam tsnoam merged commit 284f16b into python-telegram-bot:master Apr 29, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 91.578%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@whipermr5 whipermr5 deleted the whipermr5:gae-urllib3-support branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment