Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libcst as install_requires, print errors to stderr & return 1/0, add pre-commit hook & update config, #161

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Mar 21, 2023

Didn't come up with any good ways of writing an automated test for pre-commit, but tested it locally and against my fork - and therefore finding the catastrophically bad errors in init & setup 😅
I was a bit surprised missing libcst wasn't picked up by tox, but that's because the testenv depends on hypothesmith - which requires libcst.

We surely want to start tagging releases though, I looked at shed's CI workflow if there were anything there that automatically created tags but didn't find anything so I'm a bit curious if/how you automate that or if you manually do it on releasing.

@jakkdl
Copy link
Member Author

jakkdl commented Mar 21, 2023

rejigged the tests a bit to have two tests explicitly for SystemExit.

@jakkdl jakkdl mentioned this pull request Mar 21, 2023
63 tasks
@Zac-HD Zac-HD merged commit 783b5d0 into python-trio:main Mar 22, 2023
@Zac-HD
Copy link
Member

Zac-HD commented Mar 22, 2023

I looked at shed's CI workflow if there were anything there that automatically created tags but didn't find anything so I'm a bit curious if/how you automate that or if you manually do it on releasing.

Automated via this ci config invoking this janky code! It's not pretty, but it works 😅

@jakkdl
Copy link
Member Author

jakkdl commented Mar 22, 2023

haha that's some beautiful jank! I'll add it in a PR

@jakkdl jakkdl deleted the pre_commit_support branch March 22, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants