Bump requirements versions #23
Conversation
We still use tornado 4.5, because the API of tornado 5.0 has significantly changed.
`pytest` alone is deprecated.
| pytest-timeout==1.2.0 | ||
| pytest==3.4.0 | ||
| gcp-devrel-py-tools==0.0.7 | ||
| pytest-random-order==0.6.0 |
There was a problem hiding this comment.
I originally added this to help track down the weird timeout bug we were hitting on Windows, and then forgot to remove it. But maybe it's useful to keep -- what do you think?
There was a problem hiding this comment.
I do like it! It can be surprising/annoying at times, but I've seen enough tests depending on each other to know that it can help detect annoying issues earlier.
There was a problem hiding this comment.
However it seems to break --failed-first, which is possibly more useful.
dev-requirements.txt
Outdated
| pytest-random-order==0.6.0 | ||
| pytest-timeout==1.2.1 | ||
| pytest==3.4.2 | ||
| gcp-devrel-py-tools==0.0.13 | ||
| h11==0.8.0 | ||
| # Temporary pin to work around: | ||
| # https://github.com/shazow/urllib3/issues/1340 | ||
| # https://github.com/shazow/urllib3/issues/1341 |
There was a problem hiding this comment.
we can delete this comment now :-) or drop the pin altogether, idk.
There are services like requires.io and pyup.io that can automatically send PRs to update pins when never versions come out, but I don't know how fancy we want to get here.
There was a problem hiding this comment.
I removed the comment, thanks!
I think pyup.io/requires.io are a good idea, even if I never tried them. Which one would you choose?
|
OK cool! We should also fix it so that |
|
Okay, I added https://github.com/njsmith/urllib3/issues/25 for the import niceties we need. |
|
Oh, sorry, I missed seeing your latest comments. Re: We have pyup.io running on the manylinux repo, and python-hyper uses requires.io... I really don't have any reason to prefer one or the other. They both seem to work fine I guess, though I'm not sure if they can handle our weird branch setup or not. |
The exception is tornado which is still pinned at 4.x.
Maybe we should use ~= to pin to major versions?