This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Take two: Ensure import urllib3 can succeed even if trio and twisted aren't installed
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urllib3 is always built with both async and sync support, the real question is "are we in async or bleached code?" We answer this question by testing for async support in a bleached part of the code.
oliland
reviewed
Jun 27, 2018
| @@ -0,0 +1,12 @@ | |||
| class Backend: | |||
There was a problem hiding this comment.
if this has to be py2 and 3 compatible, do we need to specify (object) here to guarantee new style classes?
oliland
reviewed
Jun 27, 2018
| from ..backends import Backend | ||
|
|
||
|
|
||
| class Loader: |
There was a problem hiding this comment.
do we need to specify (object) here?
oliland
approved these changes
Jun 27, 2018
|
@oliland Thanks for the review! You really did most of the work, including the import investigation: it was easy to add the finishing touches. I think new-style classes are fine because we only support Python 2.7 which supports them. Did I miss something? |
|
Sorry, I did not leave you a lot of time to answer, but since you approved and since I think this PR does not contain new Python 2.7 issues, I'll go ahead and merge this. Thanks for your hard work, @oliland! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on @oliland's PR and completes it:
So the point of that test is simply to know whether we're running in async mode or bleached mode. We can only run in async mode with a Python that supports everything we need (3.6 right now), so the test is simple but has to be in a part of the code that is going to be bleached.
I decided to put this in _async/connection.py because it's the last place that accepts a backend, which means we can validate the backend in a single place. (Which also means that we did not really need to separate normalize_backend and load_backend.)
The history is getting a little complicated but the diff is not that big: I would recommend reviewers to look at the whole diff instead of individual commits.