Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to anyio 3.x #33

Merged
merged 5 commits into from Apr 15, 2022
Merged

upgrade to anyio 3.x #33

merged 5 commits into from Apr 15, 2022

Conversation

belm0
Copy link
Member

@belm0 belm0 commented Apr 15, 2022

Upgrade to anyio 3.x API, which implies dropping Curio support.

Along the way:

  • introduce Server.serve_async(). Use of serve() is strongly
    discouraged because it runs a full event loop.
  • add ssl test coverage
  • tests use an ephemeral port
  • update example in README. Don't encourage passing
    backend='uvloop' to anyio.run(), since it relies on runtime
    patching.

Fixes #31

  * drop curio support
  * Server SSL support is disabled for now (there was no test
    coverage anyway)
  * introduce Server.serve_async().  Use of serve() is strongly
    discouraged because it runs a full event loop.
  * update example in README.  Don't encourage passing
    backend='uvloop' to anyio.run(), since it relies on runtime
    patching.
Copy link

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple of comments, but nothing critical.

misc/greeter/failing_client.py Show resolved Hide resolved
src/purerpc/grpc_socket.py Outdated Show resolved Hide resolved
@belm0 belm0 merged commit 07b1aec into master Apr 15, 2022
@belm0 belm0 deleted the anyio3 branch April 15, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anyio dependency is too limited
2 participants