-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin CI build dependencies #137
Comments
👍 on pinning dev dependencies like pytest, sphinx and such. Pinning trio/wsproto has some tradeoffs however - it keeps things stable but can cause bugs and breaking changes in the dependencies to be missed, unless regularly updated. My opinion is that it's better not to pin them. |
Noted. So the distinction is regarding direct package dependencies-- you don't want incompatibilities or runtime errors to be hidden until your users hit them. On the other hand I've found having pinning in place for everything to be useful-- for example in other projects there is a build variant against older versions of Trio. It wouldn't be hard to add another variant for the latest package dependencies (via |
this is done |
currently the dev / CI build does not have pinned dependencies, so the build might use different package versions over time
suggested:
pip-compile
(from pip-tools) to generate dev-dependencies.txt from setup.py and dev-dependencies.infrom there, pip-compile can be used as needed to upgrade dev build dependencies
The text was updated successfully, but these errors were encountered: