Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin CI build dependencies #137

Closed
belm0 opened this issue Jun 17, 2020 · 3 comments · Fixed by #139
Closed

pin CI build dependencies #137

belm0 opened this issue Jun 17, 2020 · 3 comments · Fixed by #139

Comments

@belm0
Copy link
Member

belm0 commented Jun 17, 2020

currently the dev / CI build does not have pinned dependencies, so the build might use different package versions over time

suggested:

  • create a dev-dependencies.in
  • use pip-compile (from pip-tools) to generate dev-dependencies.txt from setup.py and dev-dependencies.in

from there, pip-compile can be used as needed to upgrade dev build dependencies

@bluetech
Copy link
Member

👍 on pinning dev dependencies like pytest, sphinx and such.

Pinning trio/wsproto has some tradeoffs however - it keeps things stable but can cause bugs and breaking changes in the dependencies to be missed, unless regularly updated. My opinion is that it's better not to pin them.

@belm0
Copy link
Member Author

belm0 commented Nov 14, 2020

Pinning trio/wsproto has some tradeoffs however - it keeps things stable but can cause bugs and breaking changes in the dependencies to be missed, unless regularly updated. My opinion is that it's better not to pin them.

Noted. So the distinction is regarding direct package dependencies-- you don't want incompatibilities or runtime errors to be hidden until your users hit them.

On the other hand I've found having pinning in place for everything to be useful-- for example in other projects there is a build variant against older versions of Trio. It wouldn't be hard to add another variant for the latest package dependencies (via pip-compile -P).

belm0 added a commit to belm0/trio-websocket that referenced this issue Nov 14, 2020
@belm0
Copy link
Member Author

belm0 commented Nov 14, 2020

It wouldn't be hard to add another variant for the latest package dependencies

this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants