Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.8 as supported runtime #135

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Conversation

AutomatedTester
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 17, 2020

Pull Request Test Coverage Report for Build 95

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.492%

Totals Coverage Status
Change from base Build 93: 0.0%
Covered Lines: 466
Relevant Lines: 488

💛 - Coveralls

@AutomatedTester
Copy link
Contributor Author

Updated the pytest requirement as Travis was pulling an older version for some reason.

@@ -31,6 +31,7 @@
'Programming Language :: Python :: 3.5',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehaase there is no CI coverage for 3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see there is #112 for that and I am happy to add it into this PR to get rid of it unless you want to support it. I only need 3.6+

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I forgot about #112 and PR #84

PR contribution is welcome, but that should be a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised #138

@belm0
Copy link
Member

belm0 commented Jun 17, 2020

Updated the pytest requirement as Travis was pulling an older version for some reason.

Well, the CI dependencies are not pinned. Opened #137.

But yes, I recall that 3.8 needs a more recent pytest-- I assume you were hitting that.

@AutomatedTester
Copy link
Contributor Author

Updated the pytest requirement as Travis was pulling an older version for some reason.

Well, the CI dependencies are not pinned. Opened #137.

But yes, I recall that 3.8 needs a more recent pytest-- I assume you were hitting that.

It's not a 3.8 issue per se but the latest pytest-cov need 4.6 or later. I didn't hit it locally since I got the latest version from pypi but weirdly travis seemed to pick up pytest 4.3 so it failed.

@belm0 belm0 merged commit b798551 into python-trio:master Jun 17, 2020
@AutomatedTester AutomatedTester deleted the py38 branch June 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants