Remove deprecated BlockingTrioPortal

[pquentin]

TODO

• coverage
• newsfragment

[oremanj]

I think we might still need this for the case where the user passes the trio_token?

[pquentin]

I have no idea, I just grepped for BlockingTrioPortal, but I'm not familiar with those APIs. @njsmith Can you please confirm?

[njsmith]

I think @oremanj is right. The test case would be something like:

async def test():
    trio_token = trio.lowlevel.current_trio_token()
    with pytest.raises(RuntimeError):
        trio.from_thread.run_sync(lambda: None, trio_token=trio_token)

If we fail to detect we're calling from_thread inside the Trio thread, then this will deadlock.

[codecov]

Codecov Report

Merging #1574 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         111      111              
  Lines       13869    13840      -29     
  Branches     1060     1055       -5     
==========================================
- Hits        13827    13798      -29     
  Misses         27       27              
  Partials       15       15              

Impacted Files	Coverage Δ
trio/__init__.py	100.00% <ø> (ø)
trio/_threads.py	100.00% <ø> (ø)
trio/tests/test_exports.py	97.22% <ø> (-0.15%)	⬇️
trio/tests/test_threads.py	100.00% <100.00%> (ø)

[pquentin]

The coverage change happens in public_modules:

I think we still want to ignore names starting with _ for future deprecations, so should I add two nocover pragmas?

[njsmith]

I think we still want to ignore names starting with _ for future deprecations, so should I add two nocover pragmas?

That seems reasonable, yeah.

[njsmith]

Looks like there are a few more coverage changes still?

[njsmith]

So close... now the last line of the new test is causing a partial coverage line, because the lambda: None never gets called. Good place for a # pragma, or I guess we could make it more specific by writing it like

def not_called():  # pragma: no cover
    assert False

from_thread_run_sync(not_called, trio_token=trio_token)

[pquentin]

Thanks for investigating! This was subtle. I found about it independently, and only because I generated an HTML report that explcitly mentioned the lambda. I think passing a None functiom is simpler, and it fixes the issue too.

[njsmith]

We'll just have to switch back to passing a function when we eventually get type hints working :-) But, up to you. Feel free to merge when you're happy.

[pquentin]

Thanks! Right, I forgot about mypy, your version is better, thanks.