Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #2971

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 13, 2024

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (f890f8f) to head (ec4c012).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2971   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         117      117           
  Lines       17594    17594           
  Branches     3171     3171           
=======================================
  Hits        17532    17532           
  Misses         43       43           
  Partials       19       19           
Files Coverage Δ
src/trio/_channel.py 100.00% <100.00%> (ø)
src/trio/_core/_mock_clock.py 100.00% <100.00%> (ø)
src/trio/_core/_run.py 99.66% <ø> (ø)
src/trio/_deprecate.py 100.00% <100.00%> (ø)
src/trio/_sync.py 100.00% <100.00%> (ø)
src/trio/_threads.py 100.00% <ø> (ø)
src/trio/_util.py 100.00% <100.00%> (ø)

@A5rocks
Copy link
Contributor

A5rocks commented Mar 13, 2024

Not sure if we should still have these configured given #2970

@CoolCat467 what do you think?

@CoolCat467
Copy link
Contributor

I do agree to some extent, #2970 does kind of make these auto-updated redundant, but I personally kind of like them because it runs way more often and does auto-fixes automatically.

@CoolCat467
Copy link
Contributor

pre-commit.ci autofix

Copy link
Contributor

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an update added catching and fixes for more types of format -> f-string conversions!

src/trio/_channel.py Show resolved Hide resolved
src/trio/_threads.py Outdated Show resolved Hide resolved
src/trio/_util.py Outdated Show resolved Hide resolved
Co-authored-by: Mike Nerone <mike@nerone.org>
@CoolCat467 CoolCat467 merged commit e3fd384 into master Mar 16, 2024
52 checks passed
@CoolCat467 CoolCat467 deleted the pre-commit-ci-update-config branch March 16, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants