Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit autoupdate to autodeps #2970

Merged

Conversation

CoolCat467
Copy link
Contributor

This pull request adds pre-commit run --jobs 0 to the autodeps run.

I didn't see this listed in the documentation anywhere, but marking 0 for number of jobs uses maximum number of threads.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (b541b8b) to head (db2fe5b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2970   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         117      117           
  Lines       17643    17643           
  Branches     3176     3176           
=======================================
  Hits        17581    17581           
  Misses         43       43           
  Partials       19       19           

@CoolCat467 CoolCat467 requested a review from A5rocks March 11, 2024 03:12
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Passing in 0 as the number of threads meaning all threads feels like a convention at this point.

@jakkdl jakkdl merged commit 379d99b into python-trio:master Mar 11, 2024
28 checks passed
@jakkdl
Copy link
Member

jakkdl commented Mar 11, 2024

nice!

@CoolCat467 CoolCat467 deleted the autodeps-pre-commit-autoupdate branch March 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants