Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cryptography 3.0 #219

Closed
wants to merge 1 commit into from

Conversation

pquentin
Copy link
Member

Unlike #218, we test the new version on Python 2 too.

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #219 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          385       385           
  Branches        25        25           
=========================================
  Hits           385       385           

Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,2 +1,7 @@
[bdist_wheel]
universal=1

[tool:pytest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I dislike putting a pytest config into a packaging-related file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pending pending deprecation pytest-dev/pytest#3523

the pyproject.toml is preferred

Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test-requirements-py3.txt now contains cryptography>3

@pquentin pquentin closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants