-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cryptography 3.0 #219
Conversation
b01c525
to
faea7b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 385 385
Branches 25 25
=========================================
Hits 385 385 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,2 +1,7 @@ | |||
[bdist_wheel] | |||
universal=1 | |||
|
|||
[tool:pytest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I dislike putting a pytest config into a packaging-related file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's pending pending deprecation pytest-dev/pytest#3523
the pyproject.toml is preferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test-requirements-py3.txt now contains cryptography>3
Unlike #218, we test the new version on Python 2 too.