Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to issues #44

Merged
merged 5 commits into from
Oct 21, 2019
Merged

Conversation

RatanShreshtha
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files           4        4           
  Lines         168      168           
  Branches       40       40           
=======================================
  Hits          162      162           
  Misses          2        2           
  Partials        4        4

@pquentin
Copy link
Member

Okay so regarding the build failure, as you know it has nothing to do with your changes, our build just become broken since the last build that happened four months ago because of a new warning.

We can't fix this warning as it looks like the issue should be fixed by setuptools, possibly in pypa/setuptools#1855. The pytest.ini change was probably correct, but you need to do this and to remove -W error because it looks like if we set -W error then the pytest.ini configuration is ignored, see https://docs.pytest.org/en/latest/warnings.html#deprecationwarning-and-pendingdeprecationwarning:

If warnings are configured at the interpreter level, using the PYTHONWARNINGS environment variable or the -W command-line option, pytest will not configure any filters by default.

Also pytest doesn’t follow PEP-0506 suggestion of resetting all warning filters because it might break test suites that configure warning filters themselves by calling warnings.simplefilter (see issue #2430 for an example of that).

@pquentin pquentin merged commit b5d11b4 into python-trio:master Oct 21, 2019
@pquentin
Copy link
Member

Thank you!

@RatanShreshtha RatanShreshtha deleted the fix_issue_link branch October 22, 2019 05:53
@pquentin
Copy link
Member

I just stumbled upon it, the correct issue in setuptools is pypa/setuptools#479, so that confirms they need to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants