do not cache signatures: some guys uses mutable defaults

python-useful-helpers · Apr 30, 2019 · eebf447 · eebf447
1 parent a099e73
commit eebf447
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/logwrap/log_wrap.py b/logwrap/log_wrap.py
@@ -578,12 +578,12 @@ def _get_function_wrapper(
         :return: wrapped coroutine or function
         :rtype: typing.Callable
         """
-        sig: inspect.Signature = inspect.signature(self._spec or func)
 
         # pylint: disable=missing-docstring
         # noinspection PyCompatibility,PyMissingOrEmptyDocstring
         @functools.wraps(func)
         async def async_wrapper(*args, **kwargs):  # type: (typing.Any, typing.Any) -> typing.Any
+            sig: inspect.Signature = inspect.signature(self._spec or func)
             args_repr: str = self._get_func_args_repr(sig=sig, args=args, kwargs=kwargs)
 
             try:
@@ -600,6 +600,7 @@ async def async_wrapper(*args, **kwargs):  # type: (typing.Any, typing.Any) -> t
         # noinspection PyCompatibility,PyMissingOrEmptyDocstring
         @functools.wraps(func)
         def wrapper(*args, **kwargs):  # type: (typing.Any, typing.Any) -> typing.Any
+            sig: inspect.Signature = inspect.signature(self._spec or func)
             args_repr: str = self._get_func_args_repr(sig=sig, args=args, kwargs=kwargs)
 
             try:

diff --git a/logwrap/log_wrap.pyx b/logwrap/log_wrap.pyx
@@ -404,10 +404,10 @@ cdef class LogWrap(class_decorator.BaseDecorator):
         :return: wrapped coroutine or function
         :rtype: typing.Callable
         """
-        sig = inspect.signature(self._spec or func)
 
         @functools.wraps(func)
         async def async_wrapper(*args, **kwargs):  # type: (typing.Any, typing.Any) -> typing.Any
+            sig = inspect.signature(self._spec or func)
             args_repr = self._get_func_args_repr(sig=sig, args=args, kwargs=kwargs)
 
             try:
@@ -423,6 +423,7 @@ cdef class LogWrap(class_decorator.BaseDecorator):
 
         @functools.wraps(func)
         def wrapper(*args, **kwargs):  # type: (typing.Any, typing.Any) -> typing.Any
+            sig = inspect.signature(self._spec or func)
             args_repr = self._get_func_args_repr(sig=sig, args=args, kwargs=kwargs)
 
             try: