Added 'bdist_ext' cmdclass implementation

[pkittenis]

For modules with native code extensions, versioneer needs a build_ext command class implementation to support wheels and other binary distributions.

Added integration tests for module with extension for setuptools and pip.

Resolves #170

[pkittenis]

The _editable and _develop test failures look unrelated and also happen on master branch.

[s0undt3ch]

Current master branch accepts a dictionary for the get_cmdclass call, perhaps update th PR for that too?

[pkittenis]

Hi @s0undt3ch - not sure I understand what you mean. There have been no changes to get_cmdclass. It is used only in tests, same way as in other tests.

Can you please clarify what changes are needed?

[s0undt3ch]

https://github.com/warner/python-versioneer/blob/master/src/cmdclass.py#L10

Specifically https://github.com/warner/python-versioneer/blob/master/src/cmdclass.py#L73

[pkittenis]

Oh right, sure, thank you.

[pkittenis]

Changes requested have been made - ready for review.

[effigies]

Hi @pkittenis. We're working on reviving this project. Can you rebase/merge master to get the CI working?

[pkittenis]

• Updated for latest master.
• Updated cython source for py 3.8 compatibility.

[pkittenis]

Merged and cleaned up changes.

[effigies]

Thanks for doing this. Out of curiosity, can the .c file be generated on the fly, rather than including it directly in the repository? I'm not terribly familiar with cython, so this may be a dumb question.

[pkittenis]

It can, but it would require Cython as a dependency, hence why it is included.

[effigies]

Overall this looks reasonable to me. We've got some future-proofing to worry about with wheel, and I've made suggestions. They require you also to add packaging to the testenv:

python-versioneer/tox.ini

Lines 10 to 20 in 64a606d

	[testenv]
	# virtualenv>=14.0.0 is incompatible with python 3.2
	# flake8>=3.0.0 and pyflakes>=2.0.0 are incompatible with 2.6,3.2,3.3
	deps =
	pyflakes
	flake8
	flake8-docstrings
	wheel
	setuptools
	virtualenv<20
	pep8

[effigies]

It can, but it would require Cython as a dependency, hence why it is included.

Fair enough. A couple KB shouldn't make a huge difference. If we're going to need to re-render it periodically, it might be worth figuring out how to get a Cython dependency into the virtualenvs.

[effigies]

@pkittenis Sorry to bug you, but could you check out my suggestions? If you don't have time, I can create a PR based on this.

[pkittenis]

Thanks, yes, will take a look.

[pkittenis]

Re: cython - I'd like to hand write a simple extension function so this can be tested without needing cython.

The use of cython was more to make it compatible with future Python versions, but a simple enough native extension should remain compatible with future C-API versions.

[effigies]

Pushed a fix to the testing environment. I'm going to go ahead and merge. Thanks for this!