Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel packages with extensions do not get static version file #170

Closed
pkittenis opened this issue Jan 31, 2018 · 1 comment · Fixed by #171
Closed

Wheel packages with extensions do not get static version file #170

pkittenis opened this issue Jan 31, 2018 · 1 comment · Fixed by #171

Comments

@pkittenis
Copy link
Contributor

For packages containing native code extensions, versioneer will not bundle a static version file when creating a wheel. sdist distributions do get static file.

For example:

wget https://files.pythonhosted.org/packages/c6/76/cb7ac54f89dfb0a43dab5f15e7a7cfffc7755379af53bd833b731cca79df/ssh2_python-0.9.0-cp27-cp27m-manylinux1_x86_64.whl

ssh2/_version.py in the wheel is the git version and requires git to be installed.

The source distribution package on the other hand has the static version.
@pkittenis pkittenis mentioned this issue Jan 31, 2018
Merged
lpsinger added a commit to lpsinger/gwcelery that referenced this issue Dec 19, 2018
@lpsinger
Add version info with Versioneer
220adec 
Note that we have to build the source distribution first, and then
build the wheel from the source distribution, because Versioneer
cannot generate a valid `_version.py` file for a wheel directly
(see python-versioneer/python-versioneer#170).

Fixes #54.
@djhoese
Copy link

djhoese commented Feb 27, 2019

I'm running in to this same issue when building my package on travis CI. I think this is the same issue described in #129. Using travis' builtin deploy stuff it seems they run sdist and bdist_wheel as separate commands or at least it doesn't work as we hope/expect.

Does anyone have some work arounds for this?

@djhoese djhoese mentioned this issue Feb 27, 2019
Merged
3 tasks
@Rodrigo-Tenorio Rodrigo-Tenorio mentioned this issue Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added 'bdist_ext' cmdclass implementation pkittenis/python-versioneer
2 participants
@pkittenis @djhoese