Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update css url to https #1256

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Update css url to https #1256

merged 2 commits into from
Feb 5, 2020

Conversation

sknzl
Copy link
Contributor

@sknzl sknzl commented Feb 4, 2020

Changing the URL of leaflet.timedimension.control.min.css to the https CDN.
Related to this problem in #1231

@dstein64 dstein64 mentioned this pull request Feb 5, 2020
Closed
@sknzl
Copy link
Contributor Author

sknzl commented Feb 5, 2020

Travis CI is failing because the URL

http://oos.soest.hawaii.edu/thredds/wms/hioos/satellite/dhw_5km

is not available any more and it is used in WmsTimeDimension.ipynb to import data with OWSLib.

Going to http://oos.soest.hawaii.edu/thredds/wms/ shows the message

WARNING! WE HAVE MIGRATED TO A NEW SERVER: https://pae-paha.pacioos.hawaii.edu/thredds/. ONLY THE FOLLOWING REMAIN TO BE MIGRATED...

The correct URL should be

https://pae-paha.pacioos.hawaii.edu/thredds/wms/dhw_5km?service=WMS

I'm going to make a separate pull request.

@Conengmo Conengmo merged commit 41f8261 into python-visualization:master Feb 5, 2020
@Conengmo
Copy link
Member

Conengmo commented Feb 5, 2020

Thanks @sknzl! Also for checking that wms error. A PR is welcome :)

@sknzl sknzl mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sknzl @Conengmo