Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to tox 4.x #691

Merged
merged 1 commit into from
Jan 20, 2023
Merged

chore: migrate to tox 4.x #691

merged 1 commit into from
Jan 20, 2023

Conversation

bringhurst
Copy link
Contributor

@bringhurst bringhurst commented Jan 19, 2023

Why is this needed?

tox-wheel is a deprecated package now that tox 4.x includes wheel support.

Example error message

When this issue occurs, you may see an error message similar to:

  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/tox_wheel/plugin.py", line 6, in <module>
    import py
ModuleNotFoundError: No module named 'py'
Error: Process completed with exit code 1.

Proposed Changes

  • remove dependency on tox-wheel
  • use tox 4.x

Does this PR introduce any breaking change?

No. Build time changes only.

@bringhurst
Copy link
Contributor Author

Note that py was also removed as a dependency from pytest. See pytest-dev/pytest@19dda7c

tox-wheel is a deprecated package. tox 4.x includes wheel support.
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 94.67% // Head: 94.65% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (8febccd) compared to base (f71da5f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   94.67%   94.65%   -0.03%     
==========================================
  Files          56       57       +1     
  Lines        8338     8339       +1     
==========================================
- Hits         7894     7893       -1     
- Misses        444      446       +2     
Impacted Files Coverage Δ
kazoo/recipe/barrier.py 98.96% <0.00%> (-1.04%) ⬇️
kazoo/protocol/connection.py 96.48% <0.00%> (-0.62%) ⬇️
kazoo/client.py 98.40% <0.00%> (ø)
kazoo/__init__.py 100.00% <0.00%> (ø)
kazoo/tests/test_client.py 98.80% <0.00%> (+0.09%) ⬆️
kazoo/handlers/eventlet.py 100.00% <0.00%> (+0.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bringhurst bringhurst marked this pull request as ready for review January 19, 2023 18:44
@bringhurst
Copy link
Contributor Author

bringhurst commented Jan 19, 2023

Note that the release.yml github actions workflow should probably be tested. I'm unsure on how to trigger that.

@StephenSorriaux
Copy link
Member

Hello,

Thank you for this.

The release.yml workflow is only triggered from a tag, since it performs all the packaging and pypi upload stuff. Maybe we could add a package.yml workflow where we do the packaging stuff without performing the final pypi upload. In any cases, I feel like it should not be part of this PR. I can look into it, unless you prefer/have time to do it.

@bringhurst
Copy link
Contributor Author

bringhurst commented Jan 19, 2023

After looking at it a bit more, I agree that it shouldn't be part of this PR.

I just put together a PR over at #692 to get that conversation going.

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jeffwidman
Copy link
Member

Going to merge as don't see a reason to hold off on this. Thanks @bringhurst !

@jeffwidman jeffwidman merged commit 0c56441 into python-zk:master Jan 20, 2023
@bringhurst bringhurst deleted the tox4 branch January 22, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants