Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict while backporting issue-less PRs #440

Closed
ezio-melotti opened this issue Apr 24, 2022 · 2 comments · Fixed by #489
Closed

Conflict while backporting issue-less PRs #440

ezio-melotti opened this issue Apr 24, 2022 · 2 comments · Fixed by #489
Labels

Comments

@ezio-melotti
Copy link
Member

I was trying to backport python/cpython#32342 with cherry_picker, and:

All backport PRs had the skip issue (and skip news) labels. I also noticed that the original PR didn't have the needs backport to 3.7/3.8 labels, and after adding them and editing the title to retrigger the check, it added the message and failed the check.

I would expect it to:

  • not fail the check if the PR has a skip issue label
  • add a message to the original PR even if the needs backport to * label is missing
@DanielNoord
Copy link
Contributor

The first issue is a duplicate of #468 for which I have a fix in #487.

Should probably refocus this issue on the second issue about not posting a message on the original issue for some python versions.

@DanielNoord
Copy link
Contributor

Second issue could be closed by #489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants