Fails issue number check even with skip-issue set

[vsajip]

I created a documentation improvement PR with no issue number and with skip-issue set. There was no problem with bedevere on this, and I successfully merged the PR in due course. I then set back-port flags for 3.10 and 3.11; back-port PRs were duly created and correctly inherited the skip-issue label. There were no problems with bedevere on these, either. The 3.11 back-port PR tests ran successfully and I merged it, too. The 3.10 back-port PR is where the problem occurred, though not initially. The tests for this failed due to a suspicious.py check and, to see if this was some transient issue, I closed the PR and opened it again just to re-run the tests. At this point, bedevere failed the PR on the issue number. The problem is that the back-port PR contains the text (GH-96344) from the original PR against main; for some reason, bedevere interprets this as an invalid issue number, when it would seem that it should check for the presence of skip-issue first. This is the 3.10 back-port PR which shows the issue.

[hugovk]

I think it might be failing here, perhaps because it's expecting an issue number but it's a (backport) PR number?

bedevere/bedevere/gh_issue.py

Line 112 in bf7a01b

async def _validate_issue_number(

[vsajip]

But why would this be called when the skip-issue label is applied?

[DanielNoord]

I have a fix for this in #487. A review would be appreciated 😄

[ezio-melotti]

I just got bitten by this:

• I was backporting ci: add GitHub token permissions cpython#92999
• miss-islington created [3.11] ci: add GitHub token permissions (GH-92999) cpython#98160 for 3.11 and got
  
• I manually created [3.10] ci: add GitHub token permissions (GH-92999) cpython#98161 for 3.10 and got
  

The reason seems to be that for 3.10 I added the skip-issue label while creating the PR, whereas for 3.11 it was added after the creation. Removing and adding back the skip-issue label on 3.10 fixed the issue.

[ezio-melotti]

After merging #487 I manually created python/cpython#98163 and got:

The fix seems to work, thanks @DanielNoord!