Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass `maintainer_can_modify` when patching the PR. #163

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@Mariatta
Copy link
Member

Mariatta commented Apr 8, 2019

We used to need to pass the maintainer_can_modify flag, but now we're getting error message 422 Validation Failed for 'maintainer_can_modify' when patching the PR. (to append the bpo link)

Removing the maintainer_can_modify flag fixes the problem, I tested in command line.
Hopefully this quick fix can unblock people.

Perhaps something changed from GitHub side, but I'm not seeing anything obvious in their changelog.

Closes #162
Closes python/core-workflow#321

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #163   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1529   1529           
  Branches       86     86           
=====================================
  Hits         1529   1529
Impacted Files Coverage Δ
bedevere/bpo.py 100% <100%> (ø) ⬆️
bedevere/close_pr.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075eb14...8c855ea. Read the comment docs.

@Mariatta Mariatta merged commit ebd40d7 into python:master Apr 8, 2019

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 075eb14
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mariatta Mariatta deleted the Mariatta:issue-162 branch Apr 8, 2019

@Mariatta

This comment has been minimized.

Copy link
Member Author

Mariatta commented Apr 8, 2019

I've deployed, and went through all the failed webhook deliveries fro the past 2 days. Things seem to be looking better now: PR's edited with link to bpo, bedevere statuses are being posted, and it still seems like I'm still able to edit the affected PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.