Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment: *almost* every change needs a NEWS entry #447

Merged
merged 2 commits into from
May 6, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 2, 2022

Bedevere's comment is slightly misleading (for example):

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

Bedevere's link to the devguide begins:

Almost all changes made to the code base deserve an entry in Misc/NEWS.d.

And then details the exceptions.

Let's update Bedevere's comment to say "Almost every change ..." instead of "Every change ...".

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 2, 2022

See #439 for more alternative suggestions

@hugovk
Copy link
Member Author

hugovk commented May 6, 2022

Updated following discussion in #439.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #447 (be58893) into master (77db0d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #447   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1720      1720           
  Branches       208       208           
=========================================
  Hits          1720      1720           
Impacted Files Coverage Δ
bedevere/news.py 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants