Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 to the testing matrix #597

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

ezio-melotti
Copy link
Member

Python 3.13 support was added to the setup-python action recently:

This PR adds it to the testing matrix.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (504dc34) to head (b3b5caf).

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #597   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2149      2149           
  Branches       245       245           
=========================================
  Hits          2149      2149           
Flag Coverage Δ
Python_3.10.14 100.00% <ø> (ø)
Python_3.11.9 100.00% <ø> (ø)
Python_3.12.3 ?
Python_3.12.4 100.00% <ø> (?)
Python_3.13.0-beta.2 100.00% <ø> (?)
Python_3.8.18 100.00% <ø> (ø)
Python_3.9.19 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugovk
Copy link
Member

hugovk commented Oct 16, 2023

Marking as draft.

3.12.0 was only released a couple of weeks ago, and we were only then able to add 3.12 due to missing dependency wheels, so this PR may be sitting around for a year or so...

@hugovk hugovk marked this pull request as draft October 16, 2023 20:27
@ezio-melotti
Copy link
Member Author

The failure seems to be caused by multidict:

  ERROR: Failed building wheel for multidict
ERROR: Could not build wheels for multidict, which is required to install pyproject.toml-based projects

There are already a couple of related issues upstream:

@ezio-melotti
Copy link
Member Author

I pinned cffi==v1.17.0rc1 (with a comment to remove it once the final version is out) and that solved the failures on 3.13. Now all the checks pass.

@ezio-melotti ezio-melotti marked this pull request as ready for review June 30, 2024 04:46
@ezio-melotti ezio-melotti merged commit 1f84bfc into python:main Jun 30, 2024
10 checks passed
@ezio-melotti ezio-melotti deleted the add-py313 branch June 30, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants