-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bot to automatically close PRs that merge maintenance branch into master #168
Comments
Looking at https://api.github.com/repos/python/cpython/pulls/2901 maybe if we checked head/ref and base/ref to make sure they both aren't |
I think the main issue here is a GitHub bug; it should not be possible for a non-team member to click the "New pull request" button on the branches page. As a defense against that, we could check that |
@zware just for my own edification, what exactly does |
@brettcannon (Sorry for the delay in answer, I'm still in the midst of moving house.) |
@zware thanks for the info! And no need to apologize! This is not exactly holding anything up and real life always takes precedence over volunteer life. Hope the move is going smoothly! |
So it would seem if a PR has a |
I'm not sure about the Otherwise, sounds good to me :) |
So |
Happened twice yesterday: |
Both of those PRs are from people who have not even forked cpython. I think that they should be reported to github support (button on their profile pages) as we may not be the only target of such abuse. Let GH support investigate their history and decide on appropriate action. |
I've just sent a message to GH support about it. |
Thanks @terryjreedy @zware |
I've had a response from GH support; they're investigating those two particular users and have relayed my feedback on removing the 'new pull request' button for those with no write access. |
I've also mentioned python/cpython#3621 to GH support, and asked for an update on removing the button. |
Just reported python/cpython#3689 as well. No news on a fix, but my "feedback is being discussed internally". |
I've closed a number of PRs where contributor tries to merge one of the maintenance branches into
master
:(e.g.
3.6
intomaster
or3.5
intomaster
)python/cpython#2901
python/cpython#2784
python/cpython#2678
python/cpython#2427
python/cpython#1968
Would be great if somehow we can disallow this type of PR, or automatically close the PR once created.
From GitHub Web UI, each of these PRs are showing maybe hundreds of commits.
It's inconvenient to scroll all the way to the bottom to find the Close button 😞
The text was updated successfully, but these errors were encountered: