Skip to content

Commit

Permalink
bpo-41514: Fix buggy IDLE test (GH-21808)
Browse files Browse the repository at this point in the history
test_run method test_fatal_error failed when run twice, as with
python -m test -m test_fatal_error test_idle test_idle
because func.called was not reinitialized to 0.
This bug caused a failure on a refleak buildbot.
  • Loading branch information
terryjreedy committed Aug 10, 2020
1 parent f2e161c commit 416f0b7
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Lib/idlelib/idle_test/test_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,11 @@ def func(): "docstring"

class HandleErrorTest(unittest.TestCase):
# Method of MyRPCServer
func = Func()
@mock.patch('idlelib.run.thread.interrupt_main', new=func)
def test_error(self):
def test_fatal_error(self):
eq = self.assertEqual
with captured_output('__stderr__') as err:
with captured_output('__stderr__') as err,\
mock.patch('idlelib.run.thread.interrupt_main',
new_callable=Func) as func:
try:
raise EOFError
except EOFError:
Expand All @@ -349,7 +349,7 @@ def test_error(self):
self.assertIn('abc', msg)
self.assertIn('123', msg)
self.assertIn('IndexError', msg)
eq(self.func.called, 2)
eq(func.called, 2)

if __name__ == '__main__':
unittest.main(verbosity=2)

0 comments on commit 416f0b7

Please sign in to comment.