Skip to content

Commit

Permalink
bpo-29890: Test IPv*Interface construction with tuple argument (GH-30862
Browse files Browse the repository at this point in the history
)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit b295a92)

Co-authored-by: Humbled Drugman <humbled.drugman@gmail.com>
  • Loading branch information
miss-islington and humbdrag committed May 3, 2022
1 parent a23e472 commit 4ede781
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Lib/test/test_ipaddress.py
Expand Up @@ -580,6 +580,10 @@ def assertBadAddress(addr, details):
assertBadAddress("1.2.3.256", re.escape("256 (> 255)"))

def test_valid_netmask(self):
self.assertEqual(str(self.factory(('192.0.2.0', 24))), '192.0.2.0/24')
self.assertEqual(str(self.factory(('192.0.2.0', '24'))), '192.0.2.0/24')
self.assertEqual(str(self.factory(('192.0.2.0', '255.255.255.0'))),
'192.0.2.0/24')
self.assertEqual(str(self.factory('192.0.2.0/255.255.255.0')),
'192.0.2.0/24')
for i in range(0, 33):
Expand Down Expand Up @@ -740,6 +744,10 @@ def assertBadAddress(addr, details):
def test_valid_netmask(self):
# We only support CIDR for IPv6, because expanded netmasks are not
# standard notation.
self.assertEqual(str(self.factory(('2001:db8::', 32))),
'2001:db8::/32')
self.assertEqual(str(self.factory(('2001:db8::', '32'))),
'2001:db8::/32')
self.assertEqual(str(self.factory('2001:db8::/32')), '2001:db8::/32')
for i in range(0, 129):
# Generate and re-parse the CIDR format (trivial).
Expand Down
@@ -0,0 +1,2 @@
Add tests for :class:`ipaddress.IPv4Interface` and :class:`ipaddress.IPv6Interface` construction with tuple arguments.
Original patch and tests by louisom.

0 comments on commit 4ede781

Please sign in to comment.