bpo-29890: Test IPv*Interface construction with tuple argument #30862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kentzo sorry for tagging but any thoughts? |
|
Totally makes sense. But I'm not pulling the strings here :) |
JelleZijlstra
approved these changes
May 2, 2022
JelleZijlstra
added
needs backport to 3.9
|
I'll backport to all versions where the tests pass. |
|
Thanks @humbdrag for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-92242 is a backport of this pull request to the 3.10 branch. |
|
GH-92243 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 3, 2022
…nGH-30862) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b295a92) Co-authored-by: Humbled Drugman <humbled.drugman@gmail.com>
miss-islington
added a commit
that referenced
this pull request
May 3, 2022
) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b295a92) Co-authored-by: Humbled Drugman <humbled.drugman@gmail.com>
miss-islington
added a commit
that referenced
this pull request
May 3, 2022
) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b295a92) Co-authored-by: Humbled Drugman <humbled.drugman@gmail.com>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…nGH-30862) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b295a92) Co-authored-by: Humbled Drugman <humbled.drugman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing up https://bugs.python.org/issue29890, original PR #816.
By adding the same tests, it seems that the issue is already addressed in the latest version.
#74076
https://bugs.python.org/issue29890