Skip to content

Commit

Permalink
bpo-33524: Fix the folding of email header when max_line_length is 0 …
Browse files Browse the repository at this point in the history
…or None (GH-13391)

and there are non-ascii characters in the header.
(cherry picked from commit feac6cd)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
  • Loading branch information
miss-islington and maxking committed May 17, 2019
1 parent 9050aaf commit 5386aaf
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Lib/email/_header_value_parser.py
Expand Up @@ -68,6 +68,7 @@
"""

import re
import sys
import urllib # For urllib.parse.unquote
from string import hexdigits
from collections import OrderedDict
Expand Down Expand Up @@ -2591,7 +2592,7 @@ def _refold_parse_tree(parse_tree, *, policy):
"""
# max_line_length 0/None means no limit, ie: infinitely long.
maxlen = policy.max_line_length or float("+inf")
maxlen = policy.max_line_length or sys.maxsize
encoding = 'utf-8' if policy.utf8 else 'us-ascii'
lines = ['']
last_ew = None
Expand Down
3 changes: 2 additions & 1 deletion Lib/email/policy.py
Expand Up @@ -3,6 +3,7 @@
"""

import re
import sys
from email._policybase import Policy, Compat32, compat32, _extend_docstrings
from email.utils import _has_surrogates
from email.headerregistry import HeaderRegistry as HeaderRegistry
Expand Down Expand Up @@ -203,7 +204,7 @@ def fold_binary(self, name, value):
def _fold(self, name, value, refold_binary=False):
if hasattr(value, 'name'):
return value.fold(policy=self)
maxlen = self.max_line_length if self.max_line_length else float('inf')
maxlen = self.max_line_length if self.max_line_length else sys.maxsize
lines = value.splitlines()
refold = (self.refold_source == 'all' or
self.refold_source == 'long' and
Expand Down
13 changes: 13 additions & 0 deletions Lib/test/test_email/test_policy.py
@@ -1,4 +1,5 @@
import io
import sys
import types
import textwrap
import unittest
Expand Down Expand Up @@ -134,6 +135,18 @@ def test_policy_addition(self):
for attr, value in expected.items():
self.assertEqual(getattr(added, attr), value)

def test_fold_zero_max_line_length(self):
expected = 'Subject: =?utf-8?q?=C3=A1?=\n'

msg = email.message.EmailMessage()
msg['Subject'] = 'á'

p1 = email.policy.default.clone(max_line_length=0)
p2 = email.policy.default.clone(max_line_length=None)

self.assertEqual(p1.fold('Subject', msg['Subject']), expected)
self.assertEqual(p2.fold('Subject', msg['Subject']), expected)

def test_register_defect(self):
class Dummy:
def __init__(self):
Expand Down
@@ -0,0 +1,3 @@
Fix the folding of email header when the max_line_length is 0 or None and the
header contains non-ascii characters. Contributed by Licht Takeuchi
(@Licht-T).

0 comments on commit 5386aaf

Please sign in to comment.