New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-33524: Fix the folding of email header when max_line_length is 0 or None #13391
Conversation
@@ -0,0 +1,2 @@ | |||
Fix the folding of email header when the max_line_length is 0 or None. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear about what we are fixing this probably ought to say "...is 0 or None and the header contains non-ascii characters".
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
@bitdancer: Please replace |
Thanks @maxking for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…or None (pythonGH-13391) and there are non-ascii characters in the header. (cherry picked from commit feac6cd) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
GH-13393 is a backport of this pull request to the 3.7 branch. |
With default python (3.6) we had this issue: python/cpython#13391 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
With default python (3.6) we had this issue: python/cpython#13391 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Updated version of #6966 with requested NEWS entry since that PR looks abandoned.
Original Patch by @Licht-T
https://bugs.python.org/issue33524