Skip to content
Permalink
Browse files

bpo-30357: test_thread now uses threading_cleanup() (#1592)

test_thread: setUp() now uses support.threading_setup() and
support.threading_cleanup() to wait until threads complete to avoid
random side effects on following tests.

Co-Authored-By:  Grzegorz Grzywacz <grzegorz.grzywacz@nazwa.pl>
  • Loading branch information
vstinner and grzgrzgrz3 committed May 15, 2017
1 parent 83a2c28 commit 79ef7f8e88a4972c4aecf95cfc5cd934f1861e08
Showing with 10 additions and 0 deletions.
  1. +4 −0 Lib/test/test_thread.py
  2. +1 −0 Misc/ACKS
  3. +5 −0 Misc/NEWS
@@ -20,6 +20,7 @@ def verbose_print(arg):
with _print_mutex:
print(arg)


class BasicThreadTest(unittest.TestCase):

def setUp(self):
@@ -31,6 +32,9 @@ def setUp(self):
self.running = 0
self.next_ident = 0

key = support.threading_setup()
self.addCleanup(support.threading_cleanup, *key)


class ThreadRunningTests(BasicThreadTest):

@@ -555,6 +555,7 @@ Eric Groo
Daniel Andrade Groppe
Dag Gruneau
Filip Gruszczyński
Grzegorz Grzywacz
Thomas Guettler
Yuyang Guo
Anuj Gupta
@@ -1183,6 +1183,11 @@ Tools/Demos
Tests
-----

* bpo-30357: test_thread: setUp() now uses support.threading_setup() and
support.threading_cleanup() to wait until threads complete to avoid
random side effects on following tests. Initial patch written by Grzegorz
Grzywacz.

- bpo-30197: Enhanced functions swap_attr() and swap_item() in the
test.support module. They now work when delete replaced attribute or item
inside the with statement. The old value of the attribute or item (or None

0 comments on commit 79ef7f8

Please sign in to comment.
You can’t perform that action at this time.