Skip to content

Commit

Permalink
bpo-43723: Fix deprecation error caused by thread.setDaemon() (GH-25361)
Browse files Browse the repository at this point in the history
  • Loading branch information
tiran authored Apr 12, 2021
1 parent 3447750 commit 95bbb33
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ async def client(host, port):

# Start the server thread and wait for it to be listening.
thread = threading.Thread(target=server)
thread.setDaemon(True)
thread.daemon = True
thread.start()
addr = q.get()

Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ def start(self):
"""
self._thread = t = threading.Thread(target=self.serve_forever,
args=(self.poll_interval,))
t.setDaemon(True)
t.daemon = True
t.start()

def serve_forever(self, poll_interval):
Expand Down Expand Up @@ -901,7 +901,7 @@ def start(self):
"""
self._thread = t = threading.Thread(target=self.serve_forever,
args=(self.poll_interval,))
t.setDaemon(True)
t.daemon = True
t.start()

def serve_forever(self, poll_interval):
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_telnetlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def setUp(self):
self.sock.settimeout(60) # Safety net. Look issue 11812
self.port = socket_helper.bind_port(self.sock)
self.thread = threading.Thread(target=server, args=(self.evt,self.sock))
self.thread.setDaemon(True)
self.thread.daemon = True
self.thread.start()
self.evt.wait()

Expand Down
6 changes: 3 additions & 3 deletions Tools/ccbench/ccbench.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def run():
for i in range(nthreads):
threads.append(threading.Thread(target=run))
for t in threads:
t.setDaemon(True)
t.daemon = True
t.start()
# We don't want measurements to include thread startup overhead,
# so we arrange for timing to start after all threads are ready.
Expand Down Expand Up @@ -328,7 +328,7 @@ def run():
for i in range(nthreads):
threads.append(threading.Thread(target=run))
for t in threads:
t.setDaemon(True)
t.daemon = True
t.start()
# Wait for threads to be ready
with ready_cond:
Expand Down Expand Up @@ -460,7 +460,7 @@ def run():
for i in range(nthreads):
threads.append(threading.Thread(target=run))
for t in threads:
t.setDaemon(True)
t.daemon = True
t.start()
# Wait for threads to be ready
with ready_cond:
Expand Down

0 comments on commit 95bbb33

Please sign in to comment.