Skip to content

Commit

Permalink
bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (GH-17437)
Browse files Browse the repository at this point in the history
Make ssl tests less strict and also accept TLSv3 as the default maximum
version. This change unbreaks test_min_max_version on Fedora 32.

https://bugs.python.org/issue38815
(cherry picked from commit 34864d1)

Co-authored-by: torsava <torsava@redhat.com>
  • Loading branch information
miss-islington and torsava committed Dec 2, 2019
1 parent 4f1eaf0 commit 9e72880
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions Lib/test/test_ssl.py
Original file line number Diff line number Diff line change
Expand Up @@ -1200,12 +1200,18 @@ def test_min_max_version(self):
# RHEL 8 uses TLS 1.2 by default
ssl.TLSVersion.TLSv1_2
}
maximum_range = {
# stock OpenSSL
ssl.TLSVersion.MAXIMUM_SUPPORTED,
# Fedora 32 uses TLS 1.3 by default
ssl.TLSVersion.TLSv1_3
}

self.assertIn(
ctx.minimum_version, minimum_range
)
self.assertEqual(
ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED
self.assertIn(
ctx.maximum_version, maximum_range
)

ctx.minimum_version = ssl.TLSVersion.TLSv1_1
Expand Down

0 comments on commit 9e72880

Please sign in to comment.