-
-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) #17437
Conversation
Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32.
I believe this is not worth a news entry, but I can provide it if required. |
Once the CI passes here I will test this on the buildbots :) |
Thanks @torsava for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Testing happening here: https://buildbot.python.org/all/#/builders?tags=%2Bstable&tags=%2Bcustom |
…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>
GH-17438 is a backport of this pull request to the 3.8 branch. |
GH-17439 is a backport of this pull request to the 3.7 branch. |
…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>
Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>
Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <torsava@redhat.com>
Thank you @torsava 🎉 BTW Am I the only one who notices the "GH-NNNN" in the title and commit message? |
You're not. The guide says to put the NNNN there (because at that point there's no number) and that it's going to be replaced by the actual number upon merge. Apparently not. I'm confused. |
The PR title itself should not need the |
Good to know, thanks! |
|
…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815
…7437) Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815
Make ssl tests less strict and also accept TLSv3 as the default maximum
version. This change unbreaks test_min_max_version on Fedora 32.
https://bugs.python.org/issue38815
Automerge-Triggered-By: @tiran