Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyword: Tests for softkwlist #102158

Closed
Eclips4 opened this issue Feb 22, 2023 · 0 comments · Fixed by #102159
Closed

keyword: Tests for softkwlist #102158

Eclips4 opened this issue Feb 22, 2023 · 0 comments · Fixed by #102159
Labels
type-feature A feature request or enhancement

Comments

@Eclips4
Copy link
Member

Eclips4 commented Feb 22, 2023 •
edited by bedevere-bot
Loading

In 3.10 version python have introduced new type of keywords such as soft.
There's no tests for it, so i decided to write it =)
Follows issue at typeshed about typehints of kwlist & softkwlist, we have came to conclusion to use assertSequenceEqual in test_keywords_are_sorted instead of assertListEqual.

Linked PRs
@Eclips4 Eclips4 added the type-feature A feature request or enhancement label Feb 22, 2023
Eclips4 added a commit to Eclips4/cpython that referenced this issue Feb 22, 2023
@Eclips4
pythongh-102158: Add tests for softkwlist
411a5d6
@Eclips4 Eclips4 mentioned this issue Feb 22, 2023
Merged
@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 24, 2023
terryjreedy added a commit that referenced this issue Feb 24, 2023
@Eclips4 @terryjreedy
gh-102158: Add tests for softkwlist (#102159)
9f3ecd1 
---------

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot bedevere-bot mentioned this issue Feb 24, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 24, 2023
@Eclips4 @terryjreedy @miss-islington
pythongh-102158: Add tests for softkwlist (pythonGH-102159)
6f03396 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot bedevere-bot mentioned this issue Feb 24, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 24, 2023
@Eclips4 @terryjreedy @miss-islington
pythongh-102158: Add tests for softkwlist (pythonGH-102159)
747612d 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this issue Feb 24, 2023
@miss-islington @Eclips4 @terryjreedy
gh-102158: Add tests for softkwlist (GH-102159)
2e2ab67 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this issue Feb 24, 2023
@miss-islington @Eclips4 @terryjreedy
gh-102158: Add tests for softkwlist (GH-102159)
dd0843a 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-102158: Add tests for softkwlist Eclips4/cpython
2 participants
@terryjreedy @Eclips4