Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102158: Add tests for softkwlist #102159

Merged
merged 3 commits into from
Feb 24, 2023
Merged

gh-102158: Add tests for softkwlist #102159

merged 3 commits into from
Feb 24, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Feb 22, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Feb 22, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Feb 22, 2023
@Eclips4
Copy link
Member Author

Eclips4 commented Feb 22, 2023

I think, there's no need for NEWS.

terryjreedy
terryjreedy requested changes Feb 23, 2023
View reviewed changes
Lib/test/test_keyword.py Show resolved Hide resolved
Lib/test/test_keyword.py Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@terryjreedy
Copy link
Member

terryjreedy commented Feb 23, 2023 •
edited
Loading

I cannot remember if test improvements are generally backported.

Except for one change, I approve and would merge if no one else does.

@Eclips4 @terryjreedy
Add check for presense of _ in keyword.softkwlist
87d1c91 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@erlend-aasland
Copy link
Contributor

I cannot remember if test improvements are generally backported.

In most cases, backporting tests makes sense. Improved coverage is always a good thing.

@Eclips4
Copy link
Member Author

Eclips4 commented Feb 23, 2023

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 24, 2023
@terryjreedy terryjreedy merged commit 9f3ecd1 into python:main Feb 24, 2023
@miss-islington
Copy link
Contributor

Thanks @Eclips4 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-102198 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2023
@Eclips4 @terryjreedy @miss-islington
pythongh-102158: Add tests for softkwlist (pythonGH-102159)
6f03396 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2023
@Eclips4 @terryjreedy @miss-islington
pythongh-102158: Add tests for softkwlist (pythonGH-102159)
747612d 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-102199 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 24, 2023
miss-islington added a commit that referenced this pull request Feb 24, 2023
@miss-islington @Eclips4 @terryjreedy
gh-102158: Add tests for softkwlist (GH-102159)
2e2ab67 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Feb 24, 2023
@miss-islington @Eclips4 @terryjreedy
gh-102158: Add tests for softkwlist (GH-102159)
dd0843a 
---------

(cherry picked from commit 9f3ecd1)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@Eclips4 Eclips4 deleted the issue-102158 branch March 16, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyword: Tests for softkwlist
6 participants
@Eclips4 @bedevere-bot @terryjreedy @erlend-aasland @miss-islington @AlexWaygood